Albums functionality #14947

surinder-tsys · 2025-06-02T13:39:25Z

This PR contains the new Albums Functionality.

Library PR: nextcloud/android-library#1736

Tests written, or not not needed

surinder-tsys · 2025-06-06T14:30:31Z

Hi, @alperozturk96 there is one issue which I couldn't able to fix it. When we open Album images in preview then they don't open in proper order. Because while swiping the images which are not in current Album also shows up.
There must be something in PreviewImageActivity due to which it loads all Images.
Can you help me out how we can fix it? Do I have to create a separate Preview activity for Albums or I can utilize the existing one?

github-actions · 2025-06-17T02:11:02Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions · 2026-01-26T09:32:27Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14947.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions · 2026-01-26T09:33:52Z

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	256	259
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	479	482

SpotBugs increased!

github-actions · 2026-01-26T09:34:20Z

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

alperozturk96

Hello

Thank you for the PR.

alperozturk96 · 2026-01-27T11:05:29Z

app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt

+        notificationManager.dismissNotification()
+    }
+
+    private fun setWorkerState(user: User?) {


We should remove these worker states otherwise consumers such as FileDisplayActivity will be refreshed and instead of worker state this approach will be used details are written in the issue.

alperozturk96 · 2026-01-27T11:07:50Z

app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt

+                break
+            }
+
+            sendUploadFinishEvent(totalUploadSize, currentUploadIndex, operation, result)


Could you check this PR and see if it’s necessary to update the UI call events in the same way it was handled there?

alperozturk96 · 2026-01-27T11:15:18Z

app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt

+        /** 1. check copy validity */
+        val result: RemoteOperationResult<Any>
+
+        if (targetParentPath.startsWith(srcPath)) {


srcPath = "/Photos/Vacation" targetParentPath = "/Photos/Vacation2025"

In this case first if check will be true and we will block valid copy operation.

alperozturk96 · 2026-01-27T11:18:47Z

app/src/main/java/com/owncloud/android/ui/activity/AlbumsPickerActivity.kt

+            captionText = resources.getText(R.string.media_picker_toolbar_title).toString()
+        }
+
+        folderPickerBinding.folderPickerBtnCopy.visibility = View.GONE


You can use this pattern to remove same prefix for all items.

folderPickerBinding.run { folderPickerBtnMove.visibility = View.GONE ... ... }

alperozturk96 · 2026-01-27T11:20:36Z

app/src/main/java/com/owncloud/android/ui/activity/AlbumsPickerActivity.kt

+        }
+    }
+
+    private fun createGalleryFragment() {


private fun createGalleryFragment() { val bundle = Bundle().apply { putParcelable( OCFileListFragment.SEARCH_EVENT, SearchEvent("image/%", SearchRemoteOperation.SearchType.PHOTO_SEARCH) ) putBoolean(EXTRA_FROM_ALBUM, true) } val fragment = GalleryFragment().apply { arguments = bundle } supportFragmentManager.beginTransaction().run { add(R.id.fragment_container, fragment, TAG_LIST_OF_FOLDERS) commit() } }

alperozturk96 · 2026-01-27T11:21:21Z

app/src/main/java/com/owncloud/android/ui/activity/AlbumsPickerActivity.kt

+        }
+    }
+
+    override fun showDetails(file: OCFile?) {


You can use Unit and remove comments.

e.g.

override fun showDetails(file: OCFile?) = Unit

alperozturk96 · 2026-01-27T11:21:35Z

app/src/main/java/com/owncloud/android/ui/activity/AlbumsPickerActivity.kt

+            }
+    }
+
+    override fun onRefresh(enforced: Boolean) {


Please use Unit

alperozturk96 · 2026-01-27T11:25:08Z

app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt

+        // nothing to do here
+    }
+
+    override fun onOverflowIconClicked(file: OCFile?, view: View?) {


You can use Unit here.

surinder-tsys requested a review from tobiasKaminsky June 2, 2025 13:39

surinder-tsys force-pushed the nmc/albums branch 2 times, most recently from a42a89f to 237cbfa Compare June 2, 2025 13:44

surinder-tsys mentioned this pull request Jun 2, 2025

Albums Functionality nextmcloud/android#330

Open

AndyScherzinger requested a review from alperozturk96 June 2, 2025 14:46

AndyScherzinger added enhancement 3. to review labels Jun 2, 2025

surinder-tsys force-pushed the nmc/albums branch from f8747ef to 2771712 Compare June 6, 2025 11:59

github-actions bot added the feedback-requested label Jun 17, 2025

surinder-tsys force-pushed the nmc/albums branch 3 times, most recently from f242064 to 60a23de Compare July 10, 2025 09:19

tobiasKaminsky mentioned this pull request Feb 25, 2025

Photo view nextcloud/files-clients#71

Open

2 tasks

surinder-tsys force-pushed the nmc/albums branch from 283e6a4 to 1cb1ed2 Compare January 22, 2026 16:11

surinder-tsys added 5 commits January 22, 2026 21:42

Albums functionality.

b002404

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>

Rename .java to .kt

6724c5a

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Code refactoring and operation migrated to kotlin

a75ee4f

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Fix -> video click event, overflow menu item hide and theming add menu

63d18bc

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Fix: preview album items

a16ca0a

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

surinder-tsys force-pushed the nmc/albums branch from 1cb1ed2 to 7ad15b8 Compare January 22, 2026 16:13

upload files to album, hide video overlay icon, minor ui and bug fixes

dc27bf9

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

surinder-tsys force-pushed the nmc/albums branch from 7ad15b8 to dc27bf9 Compare January 22, 2026 18:02

surinder-tsys added 6 commits January 23, 2026 08:52

Albums functionality.

ad92185

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>

Rename .java to .kt

ec785e5

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Code refactoring and operation migrated to kotlin

99caa4d

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Fix -> video click event, overflow menu item hide and theming add menu

d0e55bb

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

Fix: preview album items

3e15e51

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

upload files to album, hide video overlay icon, minor ui and bug fixes

e97e300

Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>

alperozturk96 force-pushed the nmc/albums branch from dc27bf9 to e97e300 Compare January 23, 2026 07:52

tobiasKaminsky added 3 commits January 23, 2026 15:19

wip

2c78623

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Merge remote-tracking branch 'origin/nmc/albums' into nmc/albums

bfe0b3f

small fix

b0f5368

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

alperozturk96 requested changes Jan 27, 2026

View reviewed changes

Uh oh!

Albums functionality #14947

Are you sure you want to change the base?

Albums functionality #14947

Conversation

surinder-tsys commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

surinder-tsys commented Jun 6, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Codacy

SpotBugs

SpotBugs increased!

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

alperozturk96 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

surinder-tsys commented Jun 2, 2025 •

edited

Loading